Skip to content

Port old version of AreaDetector writer to the new interface of the file-writer

Afonso Mukai requested to merge JIRA_issue_DM-1041 into master

Created by: SkyToGround

Description of work

-Modified (completely re-wrote) the old areaDetector writing module to work with the new (ish) kafka-to-nexus interface. -Switched over to using h5cpp for writing data. -Moved supporting dataset classes from the src/schema/senv_directory to src/. -Modified and improved dataset classes. -Added a whole bunch of unit tests for the areaDetector module and dataset classes.

Issue

Closes JIRA issue DM-1041

Acceptance Criteria

I will leave this up to the reviewer.

Unit Tests

-Updated/replaced and added unit tests for the areaDetector. -Updated and added unit tests for dataset classes (in NeXusDataset.h).

Other

There is currently no source name in the areaDetector (NDArray) flatbuffer. When this change has been approved, I will add code to this module for reading it.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports