Removing NumMetadataRetry from cli11 and streamer options (!291) · Merge requests · ecdc / ess-dmsc / kafka-to-nexus · GitLab

Afonso Mukai requested to merge 289_nummetadataretry into master Sep 27, 2018

Created by: rerpha

Description of work

It's not ever used so I removed the option from cli11opt and removed it from the StreamerOptions struct.

Issue

Closes #289 (closed)

Code Review (To be filled in by the reviewer only)

Is the code of an acceptable quality?
Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).