Skip to content

Single option for kafka options

Afonso Mukai requested to merge 290_single_option_for_kafka_stream_options into master

Created by: rerpha

Description of work

Replacing the two options for kafka options that are integers and strings to one single option. As CLI11 is now used no string formatting is needed to convert the integers to strings then sent off to kafka to set up brokers etc.

Issue

Closes #290 (closed)

Acceptance Criteria

Tests pass I have tested this with an .ini file with a debugger and it parses correctly so I would assume it'd do the same for key value pairs in a command line call outside of an .ini file but haven't tested this yet.

Unit Tests

No tests modified.

Other

Updated readme to show example of new command line option.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports