Skip to content

Removed over-engineered class structure

Afonso Mukai requested to merge remove_complicated_structure into master

Created by: mattclarke

Description of work

Removed an unnecessary copy and paste class and then tidied up the remaining code. Also, fixed some minor warnings.

Issue

N/A

Acceptance Criteria

Changes have improved the code structure. No real functionality changes.

Unit Tests

Renamed a test file and adjusted some tests to match changes.

Other

N/A

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports