Skip to content

Removing implicit pointer to bool casts, removing g_N_HANDLED

Afonso Mukai requested to merge 323_commandhandler_remove_pointer_cast into master

Created by: rerpha

Description of work

Using !=nullptr to check if the pointer is null or not rather than casting to bool.

Removing g_N_HANDLED as it's not used anywhere

Issue

Closes #323 (closed)

Acceptance Criteria

CommandHandler.cpp

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports