Skip to content

Add tests for fw task

Afonso Mukai requested to merge add_tests_for_fw_task into master

Created by: mattclarke

Description of work

I wanted to add some unit tests before adding functionality for allowing the filewriter to manage filenames differently (#318 (closed)).

I have also changed some naming to match LLVM.

Issue

N/A

Acceptance Criteria

Changes are reasonable, tests pass.

Unit Tests

Added tests for FileWriterTask.

Other

N/A

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports