340 broker and topic settings as structs
Created by: mchorazak
Description of work
- Both broker and topic settings are now structs.
- Because C++ api indeed has a common interface for configuration/settings I created a SettingsInterface.h to reflect this relation.
- Currently TopicSettings are not explicitly set anywhere but
apply(rd_kafka_topic_conf_t *conf)
method is called and removing entire struct would require changes beyond kafkaW. If we want to consider it I'd suggest discussing it and creating a separate ticket.
Issue
Closes #340 (closed)
Acceptance Criteria
- BrokerSettings.h/cpp
- TopicSettings.h/cpp
- SettingsInterface.h
Functionality itself does not change
Unit Tests
n/a
Other
n/a
Code Review (To be filled in by the reviewer only)
-
Is the code of an acceptable quality? -
Do the changes function as described and is it robust?
Nominate for Group Code Review (Anyone can nominate it)
Indicate if you think the code should be reviewed in a Thursday code review session.
-
Recommend for group code review
Also, nominate it on the code_review Slack channel (does someone want to automate this?).