Streamer logs a warning if timestamp is missing
Created by: michele-brambilla
Description of work
With this PR an explicit check for a valid timestamp (i.e. > 0) in the flatbuffer message is checked. If the timestamp is not set the Streamer logs an error message and returns ProcessMessageResult::ERR
.
Issue
DM-1141
Acceptance Criteria
List the changes in functionality or code that the reviewer needs to review.
Unit Tests
- Add test for missing (i.e. > 0) timestamp field.
- Changed
StreamerTestDummyReader
class so thattimestamp(FlatbufferMessage const &Message)
returns a small, but valid value (it returns 1)
Code Review (To be filled in by the reviewer only)
-
Is the code of an acceptable quality? -
Do the changes function as described and is it robust?
Nominate for Group Code Review (Anyone can nominate it)
Indicate if you think the code should be reviewed in a Thursday code review session.
-
Recommend for group code review
Also, nominate it on the code_review Slack channel (does someone want to automate this?).