Skip to content

Fix error in `commitOffsets`

Afonso Mukai requested to merge dm1197_subscribe_to_timestamp into master

Created by: michele-brambilla

Description of work

The KafkaW::Consumer throws an error if rd_kafka_commit returns something different from RD_KAFKA_RESP_ERR_NO_ERROR. This happens for example when there are no older messages (eventually within the specified time window) in the log. According to the discussion in this ticket though

_NO_OFFSET is a "soft error", it means it didnt have to commit the offset because the current offset had already been committed.

With this PR RD_KAFKA_RESP_ERR__NO_OFFSET is not considered an error, but a waning is emitted.

Issue

DM-1197

Other

Can someone please give it a try?

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports