Skip to content

Refactoring URI class to comply with LLVM standards

Afonso Mukai requested to merge dm1192_uri_refactoring into master

Created by: rerpha

Description of work

Replace most of the functionality in URI with a regular expression which will find everything we need.

Removing scheme as it isn't used anywhere.

Will mirror this on the forwarder when it is ready

Issue

DM-1192

Acceptance Criteria

Only change is removal of is_alpha() function and replacement with std::string::find_first_of() - same functionality just a single call

Unit Tests

Tests added for double colon in scheme and port

Tests removed for scheme (scheme has now been removed)

Other

No documentation modified.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports