Skip to content

Dm1165 messages after stop time

Afonso Mukai requested to merge dm1165_messages_after_stop_time into master

Created by: michele-brambilla

Description of work

Closes DM-1165

  • make StreamerProcessTimingTest.EmptyMessageSlightlyAfterStop test pass
  • make timeouts in KafkaW::Consumer configurable via ConsumerSettings
  • speed up Streamer tests

Issue

A message just slightly after the stop time will cause a stop of the job.

This because the timeout of rd_kafka_metadata needs to be large to prevent failures in real situations. As a side effect the timeout in EmptyMessageSlightlyAfterStop was not large enough to prevent the failure of the test. One possible solution would have been increase AfterStopTime around 12s, while the chosen solution is to set a smaller timeout. A byproduct of this solution is that the timeouts are now configurable, so that we can adapt to different situations.

Acceptance Criteria

List the changes in functionality or code that the reviewer needs to review.

Unit Tests

Restored StreamerProcessTimingTest.EmptyMessageSlightlyAfterStop

Other

The parameters can't be set in the config file so far. A new ticket with this request will be opened.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports