Skip to content

re DM-1244 log container output to stdout when program terminates

Afonso Mukai requested to merge DM-1244_container_output into master

Created by: rerpha

Description of work

Adding the filewriter container output to jenkins if the program terminates. Previously this was uncaught as it would stop logging to a file (done through the command line args)

for when multiple instances of the filewriter are used, the test fixture has a try/except block in the fixture finaliser to try and log the output of both containers. otherwise it will log just the single container named "filewriter"

Issue

Closes DM-1244

Acceptance Criteria

To test:

Remove the log-file argument in one of the test inis and check the container outputs any logs to stdout

Unit Tests

None

Other

None

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports