Skip to content

test slack notifications for prs

Afonso Mukai requested to merge DM-1212_close_group into master

Created by: rerpha

Description of work

Add your own description here. The aim is provide information to help the reviewer review the PR.

Issue

If there is an associated issue, write 'Closes #XXX'

Acceptance Criteria

List the changes in functionality or code that the reviewer needs to review.

Unit Tests

Give an overview of any unit tests you have added or modified, if applicable.

Other

Give information on anything else that might be relevant to the reviewer. Such as added system tests, update documentation etc.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports