Skip to content

Dm 1153 classes to enums

Afonso Mukai requested to merge DM-1153_classes_to_enums into master

Created by: mchorazak

Issue

DM-1153

Description of work

  • turned InitResult(HDFWriterModule.h) into enum class.

  • deleted WriteResult: Earlier when writing was successful an OK status was retured. On error, one of few variants(some were unused) was returned. All kinds of errors were caught and handled in a single if(X.isError()). A timestamp and error string could be returned, timestamp was populated, but never used. Error message was used. I created custom WriterException which is thrown in places where any kind of error status was returned before. It's handled in place where errors where previously handled. On success methods just finish - they are void now.

Many tests had to be updated.

Nominate for Group Code Review

  • Nominate for code review

Merge request reports