Skip to content

Use hash instead of source name to find FB message sink

Afonso Mukai requested to merge DM-1129_source_name_and_id_hash into master

Created by: SkyToGround

Issue

  • Closes DM-1129

Description of work

  • Replaced the use of the source name to identify a message sink with a hash of the Flatbuffer ID plus source name.
  • Fixed relevant unit tests.
  • Added unit test.
  • Changed GTest to be linked statically to work with CLion on MacOSX.
  • Some minor clang-format related changes/improvements.

It is not strictly necessary to use a hash, just using the strings would be good enough in this case. The performance benefit of using a hash are minimal to non-existent. However, I would argue that a hash is a slightly cleaner design that simplifies (potential) future re-designs.

Nominate for Group Code Review

  • Nominate for code review

Merge request reports