Skip to content

Simplify streamer by removing duplicate sources list

Afonso Mukai requested to merge simplify_streamer_by_removing_duplicate_sources_list into master

Created by: matthew-d-jones

Issue

Helps with DM-1616

Description of work

For each topic there is a single DemuxTopic and Streamer. For some reason the Streamer doesn't own the DemuxTopic but it is given a reference to it every time Streamer::pollAndProcess() is called. The Streamer maintained its own map of sources for the sole purpose of checking that each incoming message matches one of its sources, but the DemuxTopic already has this information....

I think there would be further deduplification if each Streamer had, at least shared, ownership of the corresponding DemuxTopic. It would also make the relationship between them clearer. I'll likely make a PR for that soon.

Nominate for Group Code Review

  • Nominate for code review

Merge request reports