Skip to content

Replace JsonMaybe with nonstd::optional

Afonso Mukai requested to merge replace_JsonMaybe_with_nonstd_optional into master

Created by: matthew-d-jones

Description of work

wait until #485 is merged before reviewing, this is based on another feature branch

Having an implementation of optional was useful for #485 and allows us to replace JsonMaybe.

nonstd::optional has a couple of limitations which C++17 std::optional doesn't have, but otherwise has the same interface. When we can move to C++17 it'll be very straightforward to go from nonstd to std implementation.

Nominate for Group Code Review

  • Nominate for code review

Merge request reports