Skip to content

Implemented message writer thread + other required minor changes

Afonso Mukai requested to merge filter_refactor_part_1_file_writing into refactor_message_filters

Created by: SkyToGround

Issue

  • Several, can't be bothered to list them right now.

Notes

  • I had to make some minor changes to a few existing classes to make this work.
  • Despite me saying that we should not be using ASIO, I could not help but implement the writer thread using a light version of ASIO that is called ThreadedExecutor. It reduces the amount of code that I need in the actual writer implementation. It also makes it easier (for some definitions of easier) to unit test. However, it could also be argued that it makes the code harder to reason about. Please leave your thoughts about this. It is a relatively simple matter to replace it with a regular loop if you think so.

Merge request reports