Filter refactor part 4 filter on source
Created by: SkyToGround
Issue
- Several. If you read this you know of the relevant JIRA tickets.
Description of work
- There are some unused function cppcheck warnings that I still will not fix as they will be resolved properly a little bit down the road.
- Thinking a little bit more about using the
usingstatement for accessing protected members, I find that this is really the least ridiculous way of accessing a bunch of counters that really does not (currently) have any business in being public. So unless a majority of the reviewers thinks that this should change, I will leave it as is. - Based on previous discussions, I have removed the Doxygen documentation from
class SourceFilter. - There is a flow diagram that was the basis for the code implemented in this PR. If requested I can add that to the PR or otherwise make it available.