Skip to content

Revert dependency injection of executor

Afonso Mukai requested to merge revert_dependency_injection_of_executor into filter_refactor_part_6_topic_logic

Created by: matthew-d-jones

  • Reverts PartitionTests changes that were made to enable dependency injection of Executor since this turns out to be unviable.

  • Use a factory to create consumers so we avoid making real consumers in TopicTests. Since poll is not re-called in the tests we were guaranteed to have to wait for the consumer destruction timeout of 5 seconds, which on my machine is the same as the run time for all other unit tests put together.

  • Added const & for many method parameters in Topic.

  • Minor refactoring in TopicTests to aid understanding of what is being tested and why.

Merge request reports