Skip to content

ECDC-1719 Fix writer module configurations

Afonso Mukai requested to merge ECDC-1719_fix_writer_configurations into master

Created by: SkyToGround

Issue

  • ECDC-1719 (kind of)

Description of work

I pretty happy about this one. Disregarding the added unit tests and documentation, it is roughly the same number of lines of code as before but with a lot more functionality. In the process I have been fixing SEVERAL long standing grievances I have had with the file-writer. The non-detailed version of the changes are:

  • The writer module configuration names/keys have been unified.
  • Better documentation of writer module configuration options.
  • The application will now print an error message if there is a configuration that is not used (due to e.g. a typo).
  • The error reporting and handling of writer module configurations have overall been greatly improved.

Some additional notes:

  • Have made some minor fixes to some of the writer modules including removal of useless functionality.
  • Due to the previous item, I have removed a few unit tests.
  • The hs00 module is a mess. It should (probably) either be re-written or dropped entirely as it seems that no-one is using it anyway. I started improving it but then thought better.

Merge request reports