Fix issues as noted by SonarLint + enum comparison
Assignments should not be redundant Collection sizes and array length comparisons should make sense Conditionally executed code should be reachable Empty arrays and collections should be returned instead of null Local variables should not shadow class fields Null pointers should not be dereferenced Pattern Matching for "instanceof" operator should be used instead of simple "instanceof" + cast Return of boolean expressions should not be wrapped into an "if-then-else" statement Sections of code should not be commented out "switch" statements should have at least 3 "case" clauses Two branches in a conditional structure should not have exactly the same implementation
Showing
- src/main/java/org/openepics/names/rest/controller/GlobalControllerExceptionHandler.java 1 addition, 2 deletions...mes/rest/controller/GlobalControllerExceptionHandler.java
- src/main/java/org/openepics/names/util/EssNamingConvention.java 29 additions, 32 deletions...in/java/org/openepics/names/util/EssNamingConvention.java
- src/main/java/org/openepics/names/util/HolderSystemDeviceStructure.java 31 additions, 31 deletions...org/openepics/names/util/HolderSystemDeviceStructure.java
- src/main/java/org/openepics/names/util/NameElementUtil.java 0 additions, 64 deletionssrc/main/java/org/openepics/names/util/NameElementUtil.java
- src/main/java/org/openepics/names/util/NameUtil.java 0 additions, 116 deletionssrc/main/java/org/openepics/names/util/NameUtil.java
- src/main/java/org/openepics/names/util/NamingConventionUtil.java 3 additions, 1 deletion...n/java/org/openepics/names/util/NamingConventionUtil.java
- src/main/java/org/openepics/names/util/StructureElementUtil.java 9 additions, 14 deletions...n/java/org/openepics/names/util/StructureElementUtil.java
- src/main/java/org/openepics/names/util/ValidateUtil.java 16 additions, 22 deletionssrc/main/java/org/openepics/names/util/ValidateUtil.java
- src/test/java/org/openepics/names/util/NamingConventionUtilTest.java 2 additions, 1 deletion...va/org/openepics/names/util/NamingConventionUtilTest.java
Loading
Please register or sign in to comment