Fix issues as noted by SonarLint + field name in repository classes
"@Override" should be used on overriding and implementing methods "Preconditions" and logging arguments should not require evaluation "static" base class members should not be accessed via derived types Collection.isEmpty() should be used to test for emptiness Constructors of an "abstract" class should not be declared "public" Mutable fields should not be "public static" Pattern Matching for "instanceof" operator should be used instead of simple "instanceof" + cast Redundant casts should not be used Sections of code should not be commented out String literals should not be duplicated Unused assignments should be removed
Showing
- src/main/java/org/openepics/names/old/model/Device.java 6 additions, 2 deletionssrc/main/java/org/openepics/names/old/model/Device.java
- src/main/java/org/openepics/names/old/model/NamePart.java 4 additions, 1 deletionsrc/main/java/org/openepics/names/old/model/NamePart.java
- src/main/java/org/openepics/names/old/model/UserAccount.java 4 additions, 1 deletionsrc/main/java/org/openepics/names/old/model/UserAccount.java
- src/main/java/org/openepics/names/repository/DeviceGroupRepository.java 31 additions, 28 deletions...org/openepics/names/repository/DeviceGroupRepository.java
- src/main/java/org/openepics/names/repository/DeviceTypeRepository.java 31 additions, 28 deletions.../org/openepics/names/repository/DeviceTypeRepository.java
- src/main/java/org/openepics/names/repository/DisciplineRepository.java 30 additions, 27 deletions.../org/openepics/names/repository/DisciplineRepository.java
- src/main/java/org/openepics/names/repository/NameRepository.java 23 additions, 22 deletions...n/java/org/openepics/names/repository/NameRepository.java
- src/main/java/org/openepics/names/repository/SubsystemRepository.java 31 additions, 28 deletions...a/org/openepics/names/repository/SubsystemRepository.java
- src/main/java/org/openepics/names/repository/SystemGroupRepository.java 30 additions, 27 deletions...org/openepics/names/repository/SystemGroupRepository.java
- src/main/java/org/openepics/names/repository/SystemRepository.java 31 additions, 28 deletions...java/org/openepics/names/repository/SystemRepository.java
- src/main/java/org/openepics/names/repository/model/DeviceGroup.java 9 additions, 1 deletion...ava/org/openepics/names/repository/model/DeviceGroup.java
- src/main/java/org/openepics/names/repository/model/DeviceType.java 9 additions, 1 deletion...java/org/openepics/names/repository/model/DeviceType.java
- src/main/java/org/openepics/names/repository/model/Discipline.java 5 additions, 1 deletion...java/org/openepics/names/repository/model/Discipline.java
- src/main/java/org/openepics/names/repository/model/Name.java 13 additions, 1 deletionsrc/main/java/org/openepics/names/repository/model/Name.java
- src/main/java/org/openepics/names/repository/model/NameStructure.java 19 additions, 1 deletion...a/org/openepics/names/repository/model/NameStructure.java
- src/main/java/org/openepics/names/repository/model/Persistable.java 3 additions, 0 deletions...ava/org/openepics/names/repository/model/Persistable.java
- src/main/java/org/openepics/names/repository/model/Structure.java 9 additions, 1 deletion.../java/org/openepics/names/repository/model/Structure.java
- src/main/java/org/openepics/names/repository/model/Subsystem.java 9 additions, 1 deletion.../java/org/openepics/names/repository/model/Subsystem.java
- src/main/java/org/openepics/names/repository/model/System.java 9 additions, 1 deletion...ain/java/org/openepics/names/repository/model/System.java
- src/main/java/org/openepics/names/repository/model/SystemGroup.java 5 additions, 1 deletion...ava/org/openepics/names/repository/model/SystemGroup.java
Loading
Please register or sign in to comment