Skip to content
Snippets Groups Projects
  • Aleksandar Nikolic's avatar
    af57ddf8
    install-buildtools: fix "test installation" step · af57ddf8
    Aleksandar Nikolic authored
    
    The "Test installation" step fails with some harmless error messages
    (see [1]). This can however make a user think that the buildtools
    have not been installed correctly.
    
    Two reasons for the error messages:
    - some envvars in the environment-setup-<arch>-pokysdk-linux file
      start and end with double quotes (e.g., PATH) and are as such
      written into python os.environ. This leads that their usage is
      not valid later when testing the installation. This patch removes
      the double quotes before writing, if they are present.
    - if installation directory (install_dir), given through the option
      --directory, is given as a relative path, checking if the path to
      a tool (e.g., gcc) in buildtools starts it will always fail. This
      patch converts the install_dir variable to an absolute path.
    
    [1]
    ERROR: Something went wrong: tar not found in ./build-tools
    ERROR: Something went wrong: installation failed
    
    (From OE-Core rev: 69dfedfa7ee8cf1666e1292ef25028b978131fe0)
    
    Signed-off-by: default avatarAleksandar Nikolic <aleksandar.nikolic@zeiss.com>
    Signed-off-by: default avatarRichard Purdie <richard.purdie@linuxfoundation.org>
    (cherry picked from commit e4eb0b14ecf9bd2fba13260441c9d86eb348f41e)
    Signed-off-by: default avatarAleksandar Nikolic <aleksandar.nikolic@zeiss.com>
    Signed-off-by: default avatarSteve Sakoman <steve@sakoman.com>
    af57ddf8
    History
    install-buildtools: fix "test installation" step
    Aleksandar Nikolic authored
    
    The "Test installation" step fails with some harmless error messages
    (see [1]). This can however make a user think that the buildtools
    have not been installed correctly.
    
    Two reasons for the error messages:
    - some envvars in the environment-setup-<arch>-pokysdk-linux file
      start and end with double quotes (e.g., PATH) and are as such
      written into python os.environ. This leads that their usage is
      not valid later when testing the installation. This patch removes
      the double quotes before writing, if they are present.
    - if installation directory (install_dir), given through the option
      --directory, is given as a relative path, checking if the path to
      a tool (e.g., gcc) in buildtools starts it will always fail. This
      patch converts the install_dir variable to an absolute path.
    
    [1]
    ERROR: Something went wrong: tar not found in ./build-tools
    ERROR: Something went wrong: installation failed
    
    (From OE-Core rev: 69dfedfa7ee8cf1666e1292ef25028b978131fe0)
    
    Signed-off-by: default avatarAleksandar Nikolic <aleksandar.nikolic@zeiss.com>
    Signed-off-by: default avatarRichard Purdie <richard.purdie@linuxfoundation.org>
    (cherry picked from commit e4eb0b14ecf9bd2fba13260441c9d86eb348f41e)
    Signed-off-by: default avatarAleksandar Nikolic <aleksandar.nikolic@zeiss.com>
    Signed-off-by: default avatarSteve Sakoman <steve@sakoman.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.