Skip to content
Snippets Groups Projects
Commit f50e0967 authored by Purushottam Choudhary's avatar Purushottam Choudhary Committed by Steve Sakoman
Browse files

kmscube: Add patch to fix -int-conversion build error


On some platforms, `EGLNativeDisplayType` is an int instead of
a pointer, in which case the void pointer will raise
a `-Wint-conversion`.

Add change as a patch instead of updating SRCREV .
if we update SRCREV might will get compatiblity issue
with current gstreamer 1.20.7 version because SRCREV brings changes
which resolves negotiation issues encountered with V4L2 stateless
hardware video decoders when using kmscube video playback option
which has gstreamer dependency requirement to 1.22.0

(From OE-Core rev: 19a899d2ec69572e0eae4576d9fc55a7ba857309)

Signed-off-by: default avatarPurushottam Choudhary <purushottam27.kumar@lge.com>
Signed-off-by: default avatarSteve Sakoman <steve@sakoman.com>
parent 7805243c
No related branches found
No related tags found
No related merge requests found
From b2f97f53e01e07a920761e5d3e3ba22898b794a4 Mon Sep 17 00:00:00 2001
From: Eric Engestrom <eric@igalia.com>
Date: Tue, 24 Sep 2024 17:57:45 +0200
Subject: [PATCH] common: fix cast type in init_egl()
On some platforms, `EGLNativeDisplayType` is an int instead of
a pointer, in which case the void pointer will raise
a `-Wint-conversion`.
Let's cast it to the correct type directly.
Closes: https://gitlab.freedesktop.org/mesa/kmscube/-/issues/16
https://gitlab.freedesktop.org/mesa/kmscube/-/merge_requests/57
Upstream-Status: Backport [https://gitlab.freedesktop.org/mesa/kmscube/-/commit/b2f97f53e01e07a920761e5d3e3ba22898b794a4]
Signed-off-by: Purushottam Choudhary <Purushottam27.kumar@lge.com>
---
common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common.c b/common.c
index e52d480..e1e2dcf 100644
--- a/common.c
+++ b/common.c
@@ -341,7 +341,7 @@ int init_egl(struct egl *egl, const struct gbm *gbm, int samples)
egl->display = egl->eglGetPlatformDisplayEXT(EGL_PLATFORM_GBM_KHR,
gbm->dev, NULL);
} else {
- egl->display = eglGetDisplay((void *)gbm->dev);
+ egl->display = eglGetDisplay((EGLNativeDisplayType)gbm->dev);
}
if (!eglInitialize(egl->display, &major, &minor)) {
......@@ -11,8 +11,10 @@ DEPENDS = "virtual/libgles3 virtual/libgles2 virtual/egl libdrm virtual/libgbm"
LIC_FILES_CHKSUM = "file://kmscube.c;beginline=1;endline=23;md5=8b309d4ee67b7315ff7381270dd631fb"
SRCREV = "9f63f359fab1b5d8e862508e4e51c9dfe339ccb0"
SRC_URI = "git://gitlab.freedesktop.org/mesa/kmscube;branch=master;protocol=https"
SRC_URI += "file://0001-texturator-Use-correct-GL-extension-header.patch"
SRC_URI = "git://gitlab.freedesktop.org/mesa/kmscube;branch=master;protocol=https \
file://0001-texturator-Use-correct-GL-extension-header.patch \
file://0001-common-fix-cast-type-in-init_egl.patch \
"
UPSTREAM_CHECK_COMMITS = "1"
S = "${WORKDIR}/git"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment