- Sep 13, 2022
-
-
Lars Johansson authored
-
- Sep 08, 2022
-
-
Lars Johansson authored
-
- Aug 31, 2022
-
-
Lars Johansson authored
-
- Aug 30, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
Externalize logging configuration. Rearrange application.properties content. Update README file.
-
Lars Johansson authored
-
Lars Johansson authored
-
- Jul 15, 2022
-
-
Zoltan Runyo authored
-
Lars Johansson authored
Type available as query parameter instead of path parameter. Update signature to /children/{uuid}. Update signature from /children/{type}/{uuid}.
-
- Jul 14, 2022
-
-
Lars Johansson authored
Fix issue for retrieve by name/uuid. Uuid with valid format but non-existing. Fix issue for retrieve structure by parent uuid. No parent uuid for system group, discipline. Add url encoding by default for integration tests. Add and update integration tests for names and structures.
-
- Jul 13, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
Use parameters one-by-one instead of arrays. Purpose to improve usability.
-
Lars Johansson authored
Use parameters one-by-one instead of arrays. Purpose to improve usability.
-
- Jul 12, 2022
-
-
Zoltan Runyo authored
-
- Jul 09, 2022
-
-
Lars Johansson authored
Purpose to increase readability and reduce complexity.
-
Lars Johansson authored
String literals should not be duplicated
-
Lars Johansson authored
Purpose to increase readability and reduce complexity.
-
- Jul 05, 2022
-
-
Lars Johansson authored
-
- Jun 30, 2022
-
-
Lars Johansson authored
Change log handling to a service. Add log configuration.
-
- Jun 29, 2022
-
-
Lars Johansson authored
Exceptions should be either logged or rethrown but not both
-
Lars Johansson authored
-
- Jun 28, 2022
-
-
Lars Johansson authored
Update Javadoc. Update Swagger.
-
- Jun 27, 2022
-
-
Lars Johansson authored
"@Override" should be used on overriding and implementing methods "Preconditions" and logging arguments should not require evaluation "static" base class members should not be accessed via derived types Collection.isEmpty() should be used to test for emptiness Constructors of an "abstract" class should not be declared "public" Mutable fields should not be "public static" Pattern Matching for "instanceof" operator should be used instead of simple "instanceof" + cast Redundant casts should not be used Sections of code should not be commented out String literals should not be duplicated Unused assignments should be removed
-
Lars Johansson authored
Update test utility methods including order of parameters. Refactor integration tests.
-
- Jun 23, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
Fix issues in validation. Add integration tests for multiple name elements - create, update, delete. Add integration tests for multiple structure elements - create, update, delete, approve, cancel, reject.
-
Lars Johansson authored
Refactor integration tests. Allow for test of array of objects.
-
- Jun 16, 2022
-
-
Lars Johansson authored
Adjust (ease) requirements on Excel file content for upload. Required columns as in Excel templates NameElementCommand and StructureElementCommand. Other columns as in NameElement and StructureElement also allowed.
-
Lars Johansson authored
Add endpoints for names for operations create, read, update, delete. Add endpoints for structures for operations create, read, update, delete and approve, cancel, reject.
-
Lars Johansson authored
Application will generate uuid. Update validation to not allow value for uuid when create names and structures. Update integration tests.
-
Lars Johansson authored
Ensure maximum one entry is latest for any given uuid. Update integration tests.
-
- Jun 08, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
Metrics for Naming - ESS names, System structure, Device structure Metrics for Naming - # entries - all, active, deleted, pending, cancelled, rejected, other
-
- Jun 01, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
-
- May 05, 2022
-
-
Lars Johansson authored
Assignments should not be redundant Collection sizes and array length comparisons should make sense Conditionally executed code should be reachable Empty arrays and collections should be returned instead of null Local variables should not shadow class fields Null pointers should not be dereferenced Pattern Matching for "instanceof" operator should be used instead of simple "instanceof" + cast Return of boolean expressions should not be wrapped into an "if-then-else" statement Sections of code should not be commented out "switch" statements should have at least 3 "case" clauses Two branches in a conditional structure should not have exactly the same implementation
-
Lars Johansson authored
Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" Empty statements should be removed JUnit assertTrue/assertFalse should be simplified to the corresponding dedicated assertion JUnit5 test classes and methods should have default package visibility Methods and field names should not be the same or differ only by capitalization Nested "enum"s should not be declared static
-
- May 04, 2022
-
-
Lars Johansson authored
-
Lars Johansson authored
Update REST API with response codes for endpoints. Set http status codes corresponding to exceptions.
-
Lars Johansson authored
Handle exceptions in service and controller layers. Translate exceptions to http status codes in global exception handler.
-