Skip to content
Snippets Groups Projects
  1. Jul 05, 2023
  2. Jul 03, 2023
  3. Jun 16, 2023
  4. Jun 12, 2023
  5. Jun 07, 2023
  6. Jun 02, 2023
  7. May 31, 2023
    • Simon Rose's avatar
      Fix issue where modifying certain wrapper files would cause failure · 272f4d75
      Simon Rose authored
      The issue was that `git status --porcelain` formats its output in such
      a way that `make` no longer passes the variables correctly. The solution
      is simply to no longer pass the `git status` data.
      
      Note that the git status data already was not that sufficient in terms
      of recognising what changes had been made, since all it provided was
      information as to which files had been modified, not how they had been
      modified.
      272f4d75
  8. May 25, 2023
  9. May 11, 2023
  10. May 10, 2023
    • Lucas Magalhães's avatar
      Fix memory leak in parse_semver · fb57df48
      Lucas Magalhães authored
      fb57df48
    • Lucas Magalhães's avatar
      Fix possible memory leak in runScript.c · 640e5721
      Lucas Magalhães authored
      This was reported by cppcheck over require's code:
      require-ess/src/runScript.c:128:12: error: Common realloc mistake: 'line_raw' nulled but not freed upon failure [memleakOnRealloc]
            if ((line_raw = realloc(line_raw, line_raw_size *= 2)) == NULL)
                 ^
      
      Unfortunately realloc can return null, in that case if we use something
      like
      line_raw = realloc(line_raw, size);
      The memory pointed by line_raw is lost.
      640e5721
    • Lucas Magalhães's avatar
      Fix uninitialized values in require.c · b2085515
      Lucas Magalhães authored
      This was reported running cppcheck over require's code.
      require-ess/src/require.c:1002:33: error: Uninitialized variable: &modulediroffs [uninitvar]
                     dirname, module, &modulediroffs);
                                      ^
      require-ess/src/require.c:996:18: note: Assuming condition is false
            if (dirlen == 0) continue; /* ignore empty driverpath elements */
                       ^
      require-ess/src/require.c:1002:33: note: Uninitialized variable: &modulediroffs
                     dirname, module, &modulediroffs);
                                      ^
      b2085515
    • Lucas Magalhães's avatar
      Fix format overflow errors from GCC13 in require.c · 875791dc
      Lucas Magalhães authored
      In function ‘compareVersions’,
          inlined from ‘require_priv’ at .././src/require.c:1025:29:
      .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      .././src/require.c:601:28: note: in definition of macro ‘debug’
        601 |   if (requireDebug) printf(__VA_ARGS__)
            |                            ^~~~~~~~~~~
      .././src/require.c: In function ‘require_priv’:
      .././src/require.c:640:53: note: format string is defined here
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |                                                     ^~
      In function ‘compareVersions’,
          inlined from ‘require_priv’ at .././src/require.c:1025:29:
      .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      .././src/require.c:601:28: note: in definition of macro ‘debug’
        601 |   if (requireDebug) printf(__VA_ARGS__)
            |                            ^~~~~~~~~~~
      .././src/require.c: In function ‘require_priv’:
      .././src/require.c:640:53: note: format string is defined here
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |                                                     ^~
      .././src/require.c:1031:50: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
       1031 |                 printf("require: %s %s may match %s\n", module, currentFilename,
            |                                                  ^~
      875791dc
    • Lucas Magalhães's avatar
      Fix memory leak in require_priv · fd05d245
      Lucas Magalhães authored
      fd05d245
  11. May 08, 2023
  12. May 04, 2023
Loading