- Jul 05, 2023
-
-
Simon Rose authored
-
- Jul 03, 2023
-
-
Simon Rose authored
E3-1144: Restore after init See merge request e3/e3-require!140
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
E3-1126: Install metadata as the very last install step See merge request e3/e3-require!137
-
- Jun 16, 2023
-
-
Simon Rose authored
This should take place after every single architecture has been finished. If any of them fail, then the metadata file will _not_ be installed.
-
- Jun 12, 2023
-
-
Simon Rose authored
E3-1066: Refactor require.c See merge request e3/e3-require!132
-
- Jun 07, 2023
-
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
There are two changes here: * The initHookRegistrar was being run when initially when require registers itself. But this is just telling it to run `fillModuleListRecord` later, which seems cleaner to do as a part of registering require instead of indirectly. Note that the debug check can never actually happen as the variable `requireDebug` will always be 0 at this point in time. * The environment variables being set is slightly different, in the sense that if you did not `require foo` at all you did not set these environment variables at all. However, it seems to me to make more sense to either set them independent of loading a module, or perhaps not at all; either which way it seems odd that it depended on us loading a module.
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
This was a function from the original require, but it wasn't even ever used there...
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
This was only used for some older location to look for libraries and other files. We do not use that in our packaging system.
-
Simon Rose authored
-
- Jun 02, 2023
-
-
Simon Rose authored
E3-1203: Fix issue where modifying certain wrapper files would cause failure See merge request e3/e3-require!134
-
- May 31, 2023
-
-
Simon Rose authored
The issue was that `git status --porcelain` formats its output in such a way that `make` no longer passes the variables correctly. The solution is simply to no longer pass the `git status` data. Note that the git status data already was not that sufficient in terms of recognising what changes had been made, since all it provided was information as to which files had been modified, not how they had been modified.
-
- May 25, 2023
-
-
Simon Rose authored
E3-1215: Fix issue with multiple records that include dbCommon.dbd See merge request e3/e3-require!133
-
Simon Rose authored
-
- May 11, 2023
-
-
Simon Rose authored
E3-1161: Remove separate install_module target See merge request e3/e3-require!130
-
Simon Rose authored
-
Simon Rose authored
This removal allows us to remove the `hdrs` target from every module; there were only two modules that still used it, and they have both been fixed.
-
Lucas Magalhães authored
E3-1197: Fix possible memory issues See merge request e3/e3-require!131
-
- May 10, 2023
-
-
Lucas Magalhães authored
-
Lucas Magalhães authored
This was reported by cppcheck over require's code: require-ess/src/runScript.c:128:12: error: Common realloc mistake: 'line_raw' nulled but not freed upon failure [memleakOnRealloc] if ((line_raw = realloc(line_raw, line_raw_size *= 2)) == NULL) ^ Unfortunately realloc can return null, in that case if we use something like line_raw = realloc(line_raw, size); The memory pointed by line_raw is lost.
-
Lucas Magalhães authored
This was reported running cppcheck over require's code. require-ess/src/require.c:1002:33: error: Uninitialized variable: &modulediroffs [uninitvar] dirname, module, &modulediroffs); ^ require-ess/src/require.c:996:18: note: Assuming condition is false if (dirlen == 0) continue; /* ignore empty driverpath elements */ ^ require-ess/src/require.c:1002:33: note: Uninitialized variable: &modulediroffs dirname, module, &modulediroffs); ^
-
Lucas Magalhães authored
In function ‘compareVersions’, inlined from ‘require_priv’ at .././src/require.c:1025:29: .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 640 | debug("require: compareVersions(found=%s, request=%s)\n", found, request); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .././src/require.c:601:28: note: in definition of macro ‘debug’ 601 | if (requireDebug) printf(__VA_ARGS__) | ^~~~~~~~~~~ .././src/require.c: In function ‘require_priv’: .././src/require.c:640:53: note: format string is defined here 640 | debug("require: compareVersions(found=%s, request=%s)\n", found, request); | ^~ In function ‘compareVersions’, inlined from ‘require_priv’ at .././src/require.c:1025:29: .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 640 | debug("require: compareVersions(found=%s, request=%s)\n", found, request); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .././src/require.c:601:28: note: in definition of macro ‘debug’ 601 | if (requireDebug) printf(__VA_ARGS__) | ^~~~~~~~~~~ .././src/require.c: In function ‘require_priv’: .././src/require.c:640:53: note: format string is defined here 640 | debug("require: compareVersions(found=%s, request=%s)\n", found, request); | ^~ .././src/require.c:1031:50: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 1031 | printf("require: %s %s may match %s\n", module, currentFilename, | ^~
-
Lucas Magalhães authored
-
- May 08, 2023
-
-
Simon Rose authored
E3-1186: Allow tests to be run with debug architecture if specified See merge request e3/e3-require!129
-
- May 04, 2023
-
-
Simon Rose authored
-
Simon Rose authored
-
Simon Rose authored
-