Skip to content
Snippets Groups Projects
Commit 92c7a958 authored by Sky Brewer's avatar Sky Brewer
Browse files

Fix no-unused-expressions

parent 5e8dbad6
No related branches found
No related tags found
2 merge requests!497CE-2790: Prepare for 4.0.0,!486Resolve CE-2395 "Typescript start"
...@@ -216,7 +216,9 @@ export default function ChangeHostAdmin({ ...@@ -216,7 +216,9 @@ export default function ChangeHostAdmin({
setHost(value); setHost(value);
}} }}
onInputChange={(event) => { onInputChange={(event) => {
event && onHostKeyUp(event.nativeEvent); if (event) {
onHostKeyUp(event.nativeEvent);
}
}} }}
autoSelect autoSelect
filterOptions={(options) => options} filterOptions={(options) => options}
......
...@@ -197,7 +197,9 @@ export function IOCDeployDialog({ ...@@ -197,7 +197,9 @@ export function IOCDeployDialog({
resetError(); resetError();
}} }}
onInputChange={(event) => { onInputChange={(event) => {
event && onHostKeyUp(event.nativeEvent); if (event) {
onHostKeyUp(event.nativeEvent);
}
}} }}
disabled={hasActiveDeployment} disabled={hasActiveDeployment}
autoSelect autoSelect
......
...@@ -192,7 +192,9 @@ export default function IOCDetailAdmin({ ...@@ -192,7 +192,9 @@ export default function IOCDetailAdmin({
setError(null); setError(null);
}} }}
onInputChange={(event) => { onInputChange={(event) => {
event && onNameKeyUp(event.nativeEvent); if (event) {
onNameKeyUp(event.nativeEvent);
}
}} }}
disabled={isDisabled} disabled={isDisabled}
autoSelect autoSelect
...@@ -218,12 +220,14 @@ export default function IOCDetailAdmin({ ...@@ -218,12 +220,14 @@ export default function IOCDetailAdmin({
getOptionLabel={(option) => { getOptionLabel={(option) => {
return option.url; return option.url;
}} }}
onChange={(_event, value) => { onChange={(event, value) => {
setGitId(value?.id); setGitId(value?.id);
setError(null); setError(null);
}} }}
onInputChange={(event) => { onInputChange={(event) => {
event && onRepoKeyUp(event.nativeEvent); if (event) {
onRepoKeyUp(event.nativeEvent);
}
}} }}
renderInput={(params) => ( renderInput={(params) => (
<TextField <TextField
......
...@@ -20,7 +20,9 @@ export function SearchBar({ ...@@ -20,7 +20,9 @@ export function SearchBar({
search(queryString); search(queryString);
}, [search, queryString]); }, [search, queryString]);
useEffectAfterMount(() => { useEffectAfterMount(() => {
!showAnimation && !loading && setShowAnimation(true); if (!showAnimation && !loading) {
setShowAnimation(true);
}
}, [showAnimation, loading, setShowAnimation]); }, [showAnimation, loading, setShowAnimation]);
const solidTime = 1250; const solidTime = 1250;
......
...@@ -53,7 +53,9 @@ export function RecordSearch({ iocName, rowType }) { ...@@ -53,7 +53,9 @@ export function RecordSearch({ iocName, rowType }) {
); );
useEffect(() => { useEffect(() => {
urlState.record_tab && changeTab(deserialize(urlState.record_tab)); if (urlState.record_tab) {
changeTab(deserialize(urlState.record_tab));
}
}, [urlState]); }, [urlState]);
const changeTab = (tab) => { const changeTab = (tab) => {
......
...@@ -10,7 +10,7 @@ function useMountEffect(effect, deps = [], afterMount) { ...@@ -10,7 +10,7 @@ function useMountEffect(effect, deps = [], afterMount) {
} }
didMountRef.current = true; didMountRef.current = true;
return cleanup; return cleanup;
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line
}, deps); }, deps);
} }
......
...@@ -72,7 +72,9 @@ export function IOCListView() { ...@@ -72,7 +72,9 @@ export function IOCListView() {
}; };
useEffect(() => { useEffect(() => {
urlState.tab && changeTab(deserialize(urlState.tab)); if (urlState.tab) {
changeTab(deserialize(urlState.tab));
}
}, [urlState.tab]); }, [urlState.tab]);
const urlPagination = useMemo(() => { const urlPagination = useMemo(() => {
......
...@@ -94,7 +94,9 @@ export function HostListView() { ...@@ -94,7 +94,9 @@ export function HostListView() {
}; };
useEffect(() => { useEffect(() => {
urlState.tab && changeTab(deserialize(urlState.tab)); if (urlState.tab) {
changeTab(deserialize(urlState.tab));
}
}, [urlState]); }, [urlState]);
const rowsPerPage = [20, 50]; const rowsPerPage = [20, 50];
......
...@@ -78,7 +78,9 @@ export function RecordListView() { ...@@ -78,7 +78,9 @@ export function RecordListView() {
}; };
useEffect(() => { useEffect(() => {
urlState.tab && changeTab(deserialize(urlState.tab)); if (urlState.tab) {
changeTab(deserialize(urlState.tab));
}
}, [urlState]); }, [urlState]);
const urlPagination = useMemo(() => { const urlPagination = useMemo(() => {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment