Resolve CE-1924 "Tab warnings"
What this does:
- replaces conditional showing of tabs with a custom component that does this without warnings
- fixes warnings that became visible / obvious once the above was fixed
- Autocomplete prop type issues (e.g. expected a Boolean but got an object, undefined, etc)
- impure render in LokiPanel (was making state changes during render / outside an effect)
What to look for:
- Are the warnings silenced?
- Are there other warnings I missed?
Closes CE-1924
Edited by Christina Jenks
Merge request reports
Activity
Filter activity
requested review from @alexandermadsen
assigned to @christinajenks
added 14 commits
-
86b39e18...70ffe569 - 12 commits from branch
develop
- 01da81f8 - CE-1924: use common tabpanel and access control
- c37659c0 - Merge remote-tracking branch 'origin/develop' into CE-1924-tab-warnings
-
86b39e18...70ffe569 - 12 commits from branch
requested review from @domonkosgulyas and @imretoth
@alexandermadsen if this still looks good, could you please formally approve? Thanks!
mentioned in commit c7eabb0a
Please register or sign in to reply