Skip to content
Snippets Groups Projects

Resolve CE-1924 "Tab warnings"

Merged Christina Jenks requested to merge CE-1924-tab-warnings into develop

What this does:

  • replaces conditional showing of tabs with a custom component that does this without warnings
  • fixes warnings that became visible / obvious once the above was fixed
    • Autocomplete prop type issues (e.g. expected a Boolean but got an object, undefined, etc)
    • impure render in LokiPanel (was making state changes during render / outside an effect)

What to look for:

  • Are the warnings silenced?
  • Are there other warnings I missed?

Closes CE-1924

Edited by Christina Jenks

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading