Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
C
ce-deploy-ui
Manage
Activity
Members
Labels
Plan
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
ccce
dev
ce-deploy-ui
Merge requests
!390
Resolve
CE-1924
"Tab warnings"
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Resolve
CE-1924
"Tab warnings"
CE-1924-tab-warnings
into
develop
Overview
5
Commits
4
Pipelines
2
Changes
9
Merged
Christina Jenks
requested to merge
CE-1924-tab-warnings
into
develop
1 year ago
Overview
5
Commits
4
Pipelines
2
Changes
9
Expand
What this does:
replaces conditional showing of tabs with a custom component that does this without warnings
fixes warnings that became visible / obvious once the above was fixed
Autocomplete prop type issues (e.g. expected a Boolean but got an object, undefined, etc)
impure render in LokiPanel (was making state changes during render / outside an effect)
What to look for:
Are the warnings silenced?
Are there other warnings I missed?
Closes
CE-1924
Edited
1 year ago
by
Christina Jenks
0
0
Merge request reports
Activity
All activity
Filter activity
Deselect all
Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Please
register
or
sign in
to reply
Loading