Skip to content

Log message instead of program termination when structure cannot be written to nexus file

Afonso Mukai requested to merge 263_hdf_exception_nondescriptive into master

Created by: rerpha

Description of work

Lots of LLVM changes whilst I was in this file. I am aware there are many other variable names that need changing in this file but there were bits that were inconsistent such as the order of const and the variable type.

Now the forwarder will not terminate when it cannot write a particular structure to a file and continue writing the file and rest of the structures. If it cannot initialise or find the file it will still terminate.

Issue

Closes #263 (closed)

Acceptance Criteria

Mainly HDFFile.cpp and .h FileWriterTask.cpp CommandHandler.cpp

Unit Tests

Just refactored variable names so the HDF unit tests have changed slightly but nothing functional.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports